Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about renaming connections #6450

Closed
wants to merge 9 commits into from
Closed

Add warning about renaming connections #6450

wants to merge 9 commits into from

Conversation

davidculley
Copy link
Contributor

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@davidculley davidculley requested a review from a team as a code owner November 9, 2024 04:59
@vercel Vercel
Copy link

vercel bot commented Nov 9, 2024

@davidculley is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Nov 9, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 14, 2024 7:47pm

@matthewshaver
Copy link
Contributor

Thank you so much for this information @davidculley I just changed the format to a footnote and will get this merged ASAP. We appreciate the contributions

@davidculley
Copy link
Contributor Author

@matthewshaver I'm glad to contribute! Is there a way to not change the SSH key (and thereby sever the connection), just because I rename the connection? Can this be implemented?

@matthewshaver
Copy link
Contributor

@davidculley I've run this up to engineering. I'll let you know when they respond

@matthewshaver
Copy link
Contributor

@davidculley Apologize for the delayed response. What you've documented here is actually a bug. There shouldn't be a reason for the system to generate a new SSH key upon renaming the connection. The engineering team will be implementing a fix shortly.

I am going to close this PR. I appreciate you uncovering this and bringing it to our attention. Please let me know if you have any further questions

@davidculley
Copy link
Contributor Author

Awesome that I discovered an unknown bug and that the engineering team will fix it. I'm glad to contribute! Thank you, @matthewshaver, for taking care of this.

@davidculley davidculley deleted the patch-3 branch November 19, 2024 22:21
@davidculley
Copy link
Contributor Author

Hi @matthewshaver, since dbt Cloud is not open-sourced: How can I know when this fix is implemented and when it's safe to rename connections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver left review comments

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidculley @matthewshaver @mirnawong1