Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown commit for test smarter blog Lierheimer/Kumalah #6414

Open
wants to merge 23 commits into
base: current
Choose a base branch
from
Open

Markdown commit for test smarter blog Lierheimer/Kumalah #6414

wants to merge 23 commits into from

Conversation

faithebear
Copy link

@faithebear faithebear commented Nov 4, 2024 •
edited
Loading

Nov 2024

What are you changing in this pull request and why?

This blog is part of a training team Q3 initiative to bring training field experience to the developer blog. See notion task for more detail.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@faithebear faithebear requested a review from a team as a code owner November 4, 2024 19:13
@welcome Welcome
Copy link

welcome bot commented Nov 4, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 5, 2024 4:26pm

@github-actions github-actions bot added the developer blog This content fits on the developer blog. label Nov 4, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Nov 4, 2024
@github-actions github-actions bot added the size: medium This change will take up to a week to address label Nov 4, 2024
joellabes
joellabes requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rocks so hard. I'll be in DX offsite the next couple of days, but am happy for someone on @dbt-labs/product-docs to dismiss this review/approve once the last bits are mopped up!

website/blog/2024-11-04-test-smarter-not-harder.md Show resolved Hide resolved
website/blog/2024-11-04-test-smarter-not-harder.md Outdated Show resolved Hide resolved
website/blog/2024-11-04-test-smarter-not-harder.md Outdated Show resolved Hide resolved
website/blog/2024-11-04-test-smarter-not-harder.md Outdated Show resolved Hide resolved
website/blog/2024-11-04-test-smarter-not-harder.md Outdated Show resolved Hide resolved
website/blog/2024-11-04-test-smarter-not-harder.md Outdated Show resolved Hide resolved
website/blog/2024-11-04-test-smarter-not-harder.md Outdated
Comment on lines 76 to 78
- *Granularity:* primary keys are unique and not null. Duplicates throw off calculations!
- *Completeness:* columns that should always contain text, *do.* Incomplete data is less useful!
- *Formatting:* email addresses always have a valid domain. Incorrect emails may affect marketing outreach!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples here are good, I'm not convinced they need to end in !s. I also wonder if there's anything better than "less useful" for completeness?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed this in a fresh commit & expanded a bit on incomplete data usually needing to get thrown out & reducing overall analytical power

website/blog/2024-11-04-test-smarter-not-harder.md Outdated

*Stats-focused anomalies* are fluctuations that go against your expected volumes or metrics. Some examples include:

- Volume anomalies. This could be site traffic amounts that may indicate illicit behavior, or perhaps site traffic dropping one day then doubling the next, indicating that data were not loaded properly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today was the day I discovered you're a "data is plural" person.

I have no comment on this. (It's fine, you can leave it)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarified this a bit but i am a "data might be singular or plural depending on context" kind of person xD

website/blog/2024-11-04-test-smarter-not-harder.md Outdated Show resolved Hide resolved
website/blog/2024-11-04-test-smarter-not-harder.md Outdated Show resolved Hide resolved
faithebear and others added 3 commits November 5, 2024 09:09
@faithebear @joellabes
capitalize community
83b9060 
Co-authored-by: Joel Labes <[email protected]>
@faithebear @joellabes
shorten category sentence
c94293b 
Co-authored-by: Joel Labes <[email protected]>
@faithebear @joellabes
update capitalization
9fe1776 
Co-authored-by: Joel Labes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
developer blog This content fits on the developer blog. new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faithebear @joellabes @runleonarun