Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Athena quickstart #6354

Open
wants to merge 14 commits into
base: current
Choose a base branch
from
Open

Athena quickstart #6354

wants to merge 14 commits into from

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Oct 24, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

Athena quickstart

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@matthewshaver matthewshaver requested a review from a team as a code owner October 24, 2024 13:13
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Nov 8, 2024 1:14am

@matthewshaver matthewshaver marked this pull request as draft October 24, 2024 13:13
@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Oct 24, 2024
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Nov 4, 2024
@matthewshaver matthewshaver marked this pull request as ready for review November 4, 2024 17:27
@matthewshaver matthewshaver changed the title [DRAFT] Athena quickstart Athena quickstart Nov 4, 2024
@matthewshaver matthewshaver changed the title Athena quickstart DOCS-4 Athena quickstart Nov 5, 2024
@matthewshaver matthewshaver changed the title DOCS-4 Athena quickstart Athena quickstart Nov 5, 2024
amychen1776
amychen1776 reviewed Nov 5, 2024
View reviewed changes
website/docs/guides/athena-qs.md Outdated
## Configure Amazon Athena

1. Log into your AWS account and navigate to the **Athena console**.
- If this is your first time in the Athena console (in your current AWS Region), click **Explore the query editor** to open the query editor. Otherwise, Athena opens automatically in the query editor and take one of the following actions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused about what happens with the two actions? What are the two actions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I didn't mean to put that there

runleonarun
runleonarun reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver Some initial edits.

website/docs/guides/athena-qs.md Outdated

For the following guide you can use an existing S3 bucket or create a new one.

In either case, download the following CSV files (the Jaffle Shop sample data) and load them into your S3 bucket:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following bullets are repeated above. Can we combine these secitons?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out. Not sure how I missed that

website/docs/guides/athena-qs.md Outdated

## Set up an Amazon S3 bucket

For the following guide you can use an existing S3 bucket or create a new one.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to instructions?

website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun left review comments

@amychen1776 amychen1776 Awaiting requested review from amychen1776

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewshaver @runleonarun @amychen1776