Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mssql-setup.md #6304

Open
wants to merge 5 commits into
base: current
Choose a base branch
from
Open

Update mssql-setup.md #6304

wants to merge 5 commits into from

Conversation

mikaelene
Copy link
Contributor

@mikaelene mikaelene commented Oct 17, 2024

I have changed the author back to me. Someone changed it a year or so ago. But I am the only creator and the sole owner of the PyPi-package. I kind of donated the adapter to the dbt-msft community.

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

I have changed the author back to me. Someone changed it a year or so ago. But I am the only creator and the sole owner of the PyPi-package. I kind of donated the adapter to the dbt-msft community.
@mikaelene mikaelene requested a review from a team as a code owner October 17, 2024 13:42
Copy link

vercel bot commented Oct 17, 2024

@mikaelene is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed content Improvements or additions to content labels Oct 17, 2024
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mikaelene! long time no talk. happy to have you credited. Does crediting both make sense?

My concern with giving you sole credit would be that folks might think that you're still an active maintainer of the project and bug you for updates.

How's my suggestion land with you?

@@ -4,7 +4,7 @@ description: "Read this guide to learn about the Microsoft SQL Server warehouse
id: "mssql-setup"
meta:
maintained_by: Community
authors: 'dbt-msft community (https://github.com/dbt-msft)'
authors: 'Mikael Ene'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
authors: 'Mikael Ene'
authors: 'Mikael Ene & [dbt-msft community](https://github.com/dbt-msft)'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dataders . Long time yes :-). I think maintained_by: explains who are maintaining the project. If the dbt-msft community are maintaining this, it should be stated there I guess? I mean, I did created this adapter and was the only maintainer for the first year. Previously my name was stated as author but was just removed one day, without any notification. It is a little weird to change author according to who currently maintains the project don't you think?

@mirnawong1
Copy link
Contributor

Hey @dataders just checking in to see if the proposal works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants