-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mssql-setup.md #6304
base: current
Are you sure you want to change the base?
Update mssql-setup.md #6304
Conversation
I have changed the author back to me. Someone changed it a year or so ago. But I am the only creator and the sole owner of the PyPi-package. I kind of donated the adapter to the dbt-msft community.
@mikaelene is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @mikaelene! long time no talk. happy to have you credited. Does crediting both make sense?
My concern with giving you sole credit would be that folks might think that you're still an active maintainer of the project and bug you for updates.
How's my suggestion land with you?
@@ -4,7 +4,7 @@ description: "Read this guide to learn about the Microsoft SQL Server warehouse | |||
id: "mssql-setup" | |||
meta: | |||
maintained_by: Community | |||
authors: 'dbt-msft community (https://github.com/dbt-msft)' | |||
authors: 'Mikael Ene' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
authors: 'Mikael Ene' | |
authors: 'Mikael Ene & [dbt-msft community](https://github.com/dbt-msft)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dataders . Long time yes :-). I think maintained_by: explains who are maintaining the project. If the dbt-msft community are maintaining this, it should be stated there I guess? I mean, I did created this adapter and was the only maintainer for the first year. Previously my name was stated as author but was just removed one day, without any notification. It is a little weird to change author according to who currently maintains the project don't you think?
Hey @dataders just checking in to see if the proposal works? |
I have changed the author back to me. Someone changed it a year or so ago. But I am the only creator and the sole owner of the PyPi-package. I kind of donated the adapter to the dbt-msft community.
What are you changing in this pull request and why?
Checklist