-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up legacy behavior section #5071
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
on-run-start: | ||
- '{{ ... if flags.WHICH != 'freshness' }}' | ||
``` | ||
</File> | ||
|
||
You can configure the `dbt source freshness` command to include on-run-start / on-run-end hooks in v1.8 with a planned removal in v1.9. The default value is `True`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like adding 'dbt version' initially so it's super clear
You can configure the `dbt source freshness` command to include on-run-start / on-run-end hooks in v1.8 with a planned removal in v1.9. The default value is `True`. | |
You can configure the `dbt source freshness` command to include on-run-start / on-run-end hooks in dbt version 1.8 with a planned removal in dbt version 1.9. The default value is `True`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use this language throughout our docs. I think it's understood through historical context that v1.# refers to our dbt versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, non blocker suggestion. approved!
What are you changing in this pull request and why?
Cleaning up the legacy behavior source freshness section
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/vercel.json
npm run build
to update the links that point to deleted pages