Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up legacy behavior section #5071

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Cleaning up legacy behavior section #5071

merged 1 commit into from
Mar 13, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Cleaning up the legacy behavior source freshness section

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner March 13, 2024 16:03
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 4:08pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Mar 13, 2024
@matthewshaver matthewshaver linked an issue Mar 13, 2024 that may be closed by this pull request
1 task
on-run-start:
- '{{ ... if flags.WHICH != 'freshness' }}'
```
</File>

You can configure the `dbt source freshness` command to include on-run-start / on-run-end hooks in v1.8 with a planned removal in v1.9. The default value is `True`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like adding 'dbt version' initially so it's super clear

Suggested change
You can configure the `dbt source freshness` command to include on-run-start / on-run-end hooks in v1.8 with a planned removal in v1.9. The default value is `True`.
You can configure the `dbt source freshness` command to include on-run-start / on-run-end hooks in dbt version 1.8 with a planned removal in dbt version 1.9. The default value is `True`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this language throughout our docs. I think it's understood through historical context that v1.# refers to our dbt versions.

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, non blocker suggestion. approved!

@matthewshaver matthewshaver merged commit 0551e80 into current Mar 13, 2024
11 checks passed
@matthewshaver matthewshaver deleted the legacy branch March 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global configs fast follows
2 participants