Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add clarification btw semantic.manifes.json and manifest.json #4928

Merged
merged 16 commits into from
Mar 1, 2024
Merged

add clarification btw semantic.manifes.json and manifest.json #4928

merged 16 commits into from
Mar 1, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Feb 15, 2024 •
edited
Loading

per slack conv, adding clarificaiton details btw the two files so users understand why both exist.

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@mirnawong1 mirnawong1 requested a review from a team as a code owner February 15, 2024 14:03
@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 4:37pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. and removed Docs team Authored by the Docs team @dbt Labs labels Feb 15, 2024
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Feb 20, 2024
@mirnawong1 mirnawong1 requested a review from jtcohen6 February 20, 2024 13:49
@mirnawong1
Copy link
Contributor Author

adding you here @jtcohen6 in case you have feedback. thank you!

@mirnawong1 mirnawong1 enabled auto-merge March 1, 2024 12:02
@mirnawong1 mirnawong1 merged commit 811945b into current Mar 1, 2024
4 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-26 branch March 1, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirnawong1 @matthewshaver