Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-project reference (via "project" dependency) requires upstream public model #4816

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

jtcohen6
Copy link
Collaborator

What are you changing in this pull request and why?

Per @patkearns10:

[Let's] consider enabling upstream project model access (public) as a pre-requisite here. I have seen customers not add that yml config and confused when they get an error downstream, like:

Model 'model.this_project.some_model' (models/some_model.sql) depends on a node named 'upstream_model' in package or project 'upstream_project' which was not found.

@jtcohen6 jtcohen6 requested a review from a team as a code owner January 29, 2024 09:17
Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 9:20am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 29, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you for opening this up @jtcohen6

@mirnawong1 mirnawong1 merged commit 306645b into current Jan 29, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the jerco/project-deps-prereq-upstream-public-model branch January 29, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content January-2024 size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants