-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENT-1132] Job Runner Role #4791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Improvements or additions to content
size: medium
This change will take up to a week to address
labels
Jan 24, 2024
ajaythomas
approved these changes
Jan 24, 2024
@matthewshaver Hey Matt, mind giving this one a quick review? |
matthewshaver
approved these changes
Jan 25, 2024
Looks good @aaronbini ! |
Have received word this is good to merge. Bypassing review request for Sai. All checks have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
January-2024
size: medium
This change will take up to a week to address
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
We're adding a new Job Runner role (permission set). This role will be used exclusively to kick off runs (generally by service tokens from within a third-party orchestration tool like Airflow). This PR adds this new role to our permissions table.
Note: The changes are easiest to view if you zoom the diff out so things all land on the same line.
ENT-1132
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/static/_redirects
npm run build
to update the links that point to deleted pages