Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing-sources.md for docs on running all source tests #4551

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

anubhavsharma515
Copy link
Contributor

@anubhavsharma515 anubhavsharma515 commented Nov 29, 2023

The documentation advises on running the dbt test --select source:* command for running tests on all sources. However, this syntax (with the asterisk), is not something the CLI is too happy with. Double quoting the selector resolves the error.

What are you changing in this pull request and why?

When reviewing the documentation here, specifically for running tests on all sources, my CLI throws the following error:
Screenshot 2023-11-29 at 9 56 09 AM

I believe this is as a result of the syntax rules for commands in CLI's. The proposed change follows the syntax here on dbt docs, so there's no new pattern being set.

Checklist

The documentation advises on running the `dbt test --select source:*` command for running tests on all sources. However, this syntax (with the asterisk), is not something the CLI is too happy with. Double quoting the selector resolves the error.
@anubhavsharma515 anubhavsharma515 requested a review from a team as a code owner November 29, 2023 14:53
Copy link

welcome bot commented Nov 29, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 0:15am

@github-actions github-actions bot added the content Improvements or additions to content label Nov 29, 2023
@runleonarun runleonarun added the new contributor Label for first-time contributors label Nov 29, 2023
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Nov 29, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @anubhavsharma515 thanks so much for opening this up and great callout! I'll get this merged for you! really appreciate this and looking forward to future contributions ✨

@mirnawong1 mirnawong1 enabled auto-merge December 4, 2023 12:03
@mirnawong1 mirnawong1 merged commit 1064696 into dbt-labs:current Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants