Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize images in docs repo to reduce total file size #4499

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Optimize images in docs repo to reduce total file size #4499

merged 4 commits into from
Nov 17, 2023

Conversation

thorn14
Copy link
Contributor

@thorn14 thorn14 commented Nov 16, 2023 •
edited
Loading

What are you changing in this pull request and why?

I ran ImageOptim to reduce the file size within the docs repo for images.

Stats:
Files optimized = 1,065
Max file reduction = 97.7%
Starting size = 525.7 MB
Total reduction = 249.4 MB
Total ending size = 276.3

Checklist

  • Needs review to confirm no breaking changes.

Caution, the diff view may break your browser, so here's what you will see:
Screenshot 2023-11-16 at 3 09 50 PM

@thorn14 thorn14 requested a review from JKarlavige November 16, 2023 23:13
@thorn14 thorn14 requested a review from a team as a code owner November 16, 2023 23:13
@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 2:47pm

@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person content Improvements or additions to content and removed size: large This change will more than a week to address and might require more than one person labels Nov 16, 2023
@github-actions github-actions bot added the size: large This change will more than a week to address and might require more than one person label Nov 16, 2023
JKarlavige
JKarlavige approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@JKarlavige JKarlavige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on and nearly nuking your laptop! Clicked through the preview and all looks good, verified (after it finally loaded) that all changed files only have edited images with none being deleted. lgtm! 🚢

@mirnawong1
Copy link
Contributor

tested in light and dark mode, images look great. thank you so much again @thorn14 !

@mirnawong1 mirnawong1 merged commit 5a5b274 into current Nov 17, 2023
6 checks passed
@mirnawong1 mirnawong1 deleted the dt-img-optim branch November 17, 2023 18:22
@thorn14 thorn14 mentioned this pull request Nov 13, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKarlavige JKarlavige JKarlavige approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thorn14 @mirnawong1 @JKarlavige