Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql querying docs #4496

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Update graphql querying docs #4496

merged 4 commits into from
Nov 17, 2023

Conversation

WilliamDee
Copy link
Contributor

What are you changing in this pull request and why?

  • Reordered the GQL docs to improve clarity
  • Add additional docs on the querying process

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to the deleted page

@WilliamDee WilliamDee requested a review from a team as a code owner November 16, 2023 19:25
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 9:40am

@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person labels Nov 16, 2023
@WilliamDee
Copy link
Contributor Author

A community member mentioned there was a bit of confusion on how to query via GQL https://getdbt.slack.com/archives/C02CCBBBR1D/p1699969536627599

Dimension {
name: String!
description: String
type: DimensionType!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @WilliamDee, if a user uses these parameters, does this mean the DimensionType! field needs to be filled in by them using either CATEGORICAL or TIME as state below?

DimensionType = [CATEGORICAL, TIME]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a return type so not an input type, so this is for them to retrieve certain values from the request

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much @WilliamDee ! one non-blocking question and going to get this merged for you!

@mirnawong1 mirnawong1 enabled auto-merge November 17, 2023 09:30
@mirnawong1 mirnawong1 merged commit f3e36e7 into current Nov 17, 2023
6 checks passed
@mirnawong1 mirnawong1 deleted the will/update-gql-docs branch November 17, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants