Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checklist items in pr template #4495

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Update checklist items in pr template #4495

merged 1 commit into from
Nov 16, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Nov 16, 2023 •
edited
Loading

What are you changing in this pull request and why?

Update PR template:

  • to link to how to version blocks of content
  • to run npm command instead of running cypress checks for link checking. cypress tests need to be updated so this hasn't been our workflow for some time now

closes #2861

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner November 16, 2023 16:59
@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 5:04pm

@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Nov 16, 2023
runleonarun
runleonarun approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions Thank you!

@nghi-ly nghi-ly merged commit ff2b7fc into current Nov 16, 2023
9 checks passed
@nghi-ly nghi-ly deleted the ly-docs-pr-template branch November 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
auto update Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link to versioning components within PR template
2 participants
@nghi-ly @runleonarun