-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove create_metric parameter reference from 1.6 docs #4468
Conversation
The create_metric parameter on measures defined in semantic models is listed in the 1.6 documentation, but support for it was not added until 1.7.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The preview seems really broken to me, maybe I'm on the wrong branch? This needs to only go out to 1.6, as this parameter is supported in 1.7. |
hey @tlento ! thanks for opening this up, I've created a partial so we can reuse the same table because i noticed the parameters didn't match in the 'measures' page and 'semantic models' page. i also added an asterisk so all users were aware that |
also @tlento this pr is going into the |
hey @tlento , let me know if this is good to go and if the branch is going to the correct one -- should it be current? |
Hi @mirnawong1 ! The original PR was targeted at 1-6-ga because it was a fix for the create_metric documentation in the 1.6 version of the docs site. With the new updates I think we should merge this to current. Will that back-propagate to the 1.6 version as well, or do we need to backport or something? |
Also I think everything looks great from a language perspective but I can't render the docs in vercel for some reason so I don't know what it all looks like. |
hey @tlento ! no worries, sorry you can't view the vercel preview - what error or behavior are you seeing? I'll share the staging link and screenshots too in case it helps but it's looking good on my end! I'll merge this to the current branch but let me know if you think anything needs changing. thank you again! |
What are you changing in this pull request and why?
The create_metric parameter on measures defined in semantic models is listed in the 1.6 documentation, but support for it was not added until 1.7.
This PR removes the create_metric entry from the 1.6 documentation.
Checklist