Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove create_metric parameter reference from 1.6 docs #4468

Merged
merged 12 commits into from
Nov 17, 2023

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Nov 14, 2023

What are you changing in this pull request and why?

The create_metric parameter on measures defined in semantic models is listed in the 1.6 documentation, but support for it was not added until 1.7.

This PR removes the create_metric entry from the 1.6 documentation.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

matthewshaver and others added 2 commits July 31, 2023 14:16
The create_metric parameter on measures defined in semantic models is listed in the 1.6 documentation, but support for it was not added until 1.7.
@tlento tlento requested a review from a team as a code owner November 14, 2023 19:03
Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 9:54am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Nov 14, 2023
@tlento
Copy link
Contributor Author

tlento commented Nov 14, 2023

The preview seems really broken to me, maybe I'm on the wrong branch? This needs to only go out to 1.6, as this parameter is supported in 1.7.

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Nov 15, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Nov 15, 2023
@mirnawong1
Copy link
Contributor

hey @tlento ! thanks for opening this up, I've created a partial so we can reuse the same table because i noticed the parameters didn't match in the 'measures' page and 'semantic models' page. i also added an asterisk so all users were aware that label and create_metric is available on dbt v1.7 or higher.

@mirnawong1
Copy link
Contributor

also @tlento this pr is going into the 1-6-ga branch and not current branch -- is that right?

@mirnawong1
Copy link
Contributor

hey @tlento , let me know if this is good to go and if the branch is going to the correct one -- should it be current?

@tlento
Copy link
Contributor Author

tlento commented Nov 16, 2023

Hi @mirnawong1 ! The original PR was targeted at 1-6-ga because it was a fix for the create_metric documentation in the 1.6 version of the docs site.

With the new updates I think we should merge this to current. Will that back-propagate to the 1.6 version as well, or do we need to backport or something?

@tlento
Copy link
Contributor Author

tlento commented Nov 16, 2023

Also I think everything looks great from a language perspective but I can't render the docs in vercel for some reason so I don't know what it all looks like.

@mirnawong1 mirnawong1 changed the base branch from 1-6-ga to current November 17, 2023 09:32
@mirnawong1
Copy link
Contributor

hey @tlento ! no worries, sorry you can't view the vercel preview - what error or behavior are you seeing?

I'll share the staging link and screenshots too in case it helps but it's looking good on my end!

I'll merge this to the current branch but let me know if you think anything needs changing. thank you again!

Screenshot 2023-11-17 at 09 46 49
Screenshot 2023-11-17 at 09 47 08

@mirnawong1 mirnawong1 enabled auto-merge November 17, 2023 09:48
@mirnawong1 mirnawong1 merged commit 9bb059f into current Nov 17, 2023
4 checks passed
@mirnawong1 mirnawong1 deleted the tlento-create-metric-update branch November 17, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants