-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config example for dbt_project.yml
#4443
Fix config example for dbt_project.yml
#4443
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @dbeatty10 ! though i put the yaml through a validator and it said the meta contents should look like:
semantic-models:
my_project_name:
+enabled: true | false
+group: some_group
+meta:
some_key: some_value
Good idea @mirnawong1 ! I'll make that switch. More detailThe general format is: semantic-models:
<resource-path>:
+enabled: true | false
+group: <group_name>
+meta: {<dictionary>} Either of these will achieve the same end result: semantic-models:
my_project_name:
+enabled: true | false
+group: some_group
+meta:
some_key: some_value or semantic-models:
my_project_name:
+enabled: true | false
+group: some_group
+meta: {"some_key": "some_value"} But the syntax you mentioned is more readable and writeable, so it would be best for the code examples. Thanks for noticing and putting it through the validator 💡 |
Previews
What are you changing in this pull request and why?
Within
dbt_project.yml
, resource types have dashes (-
) instead of underscores (_
), so we need to update this code example accordingly.Backstory
Within the description for #4180, I added some examples of what I guessed the syntax would be, but I didn't specify that these were completely unverified guesses 😬.
This particular example got missed during #4281.
🎩
Checklist