Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated dever-env-id to defer-env-id in Cloud CLI docs #4338

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

bthomson22
Copy link
Contributor

@bthomson22 bthomson22 commented Oct 26, 2023

What are you changing in this pull request and why?

Ref issue: #4337

This PR fixes a typo in our Cloud CLI docs, updating dever-env-id to defer-env-id.

image

Straightforward :)

I admittedly have not tested this, and I'm not even sure how - but hoping this is straightforward and perhaps doesn't require versioning?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@bthomson22 bthomson22 requested a review from a team as a code owner October 26, 2023 04:28
@welcome
Copy link

welcome bot commented Oct 26, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 9:22am

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 26, 2023
@github-actions github-actions bot added the content Improvements or additions to content label Oct 26, 2023
@bthomson22 bthomson22 changed the title Fixed typo Fix: Updated dever-env-id to defer-env-id in Cloud CLI docs Oct 26, 2023
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Oct 26, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 26, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bthomson22 , such a great catch, and thank you for opening this pr and issue up! you're totally right and I'll get this merged for you✨ appreciate you opening this up again!

@mirnawong1
Copy link
Contributor

Closes #4337

@mirnawong1 mirnawong1 merged commit efbc769 into current Oct 26, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the fix/update-typo-in-cloud-ci-deferral branch October 26, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants