Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement relation filtering on get_catalog macro #964

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Implement relation filtering on get_catalog macro #964

wants to merge 23 commits into from

Commits on Dec 16, 2023

  1. changelog

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    bbac669 View commit details
    Browse the repository at this point in the history

  2. add _get_one_catalog_by_relations method, redirect _get_one_catalog t… 

    …o this method to reduce code duplication
    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    28dd554 View commit details
    Browse the repository at this point in the history

  3. override get_catalog_by_relations to align with how get_catalog is ov… 

    …erridden
    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    b9cfd81 View commit details
    Browse the repository at this point in the history

  4. turn off get_catalog_by_relations to test

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    eab3067 View commit details
    Browse the repository at this point in the history

  5. call get_catalog by relation

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    73979ee View commit details
    Browse the repository at this point in the history

  6. guard against multiple info schemas in get_catalog_by_relations

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    17c245f View commit details
    Browse the repository at this point in the history

  7. reuse get_catalog logic, add ability to pass relations into new method

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    9b0bd5f View commit details
    Browse the repository at this point in the history

  8. redirect get_catalog_relations to get_catalog to check plumbing

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    5236d40 View commit details
    Browse the repository at this point in the history

  9. manually create schema_map so that it's limited to the relations prov… 

    …ided
    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    bf6e910 View commit details
    Browse the repository at this point in the history

  10. add check to guarantee relations is populated

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    18d30f7 View commit details
    Browse the repository at this point in the history

  11. catch exception when info_schemas is empty

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    844cfbf View commit details
    Browse the repository at this point in the history

  12. catch exception when info_schemas is empty

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    2d4d3c2 View commit details
    Browse the repository at this point in the history

  13. update the connection name

    @mikealfare
    mikealfare committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    c3e608d View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. mimic get_catalog behavior

    @mikealfare
    mikealfare committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5221389 View commit details
    Browse the repository at this point in the history

  2. mimic get_catalog behavior

    @mikealfare
    mikealfare committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    ccfeebd View commit details
    Browse the repository at this point in the history

  3. redirect to new method

    @mikealfare
    mikealfare committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    d609da9 View commit details
    Browse the repository at this point in the history

  4. error on empty list of relations

    @mikealfare
    mikealfare committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    3afd659 View commit details
    Browse the repository at this point in the history

  5. use the cached version of the relation to ensure we have column metadata

    @mikealfare
    mikealfare committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f28c181 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. move cache logic into the cache

    @mikealfare
    mikealfare committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    52b9dc5 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @mikealfare
    mikealfare committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    642bd12 View commit details
    Browse the repository at this point in the history

  3. remove whitespace fixes to reduce PR confusion

    @mikealfare
    mikealfare committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    534cd0f View commit details
    Browse the repository at this point in the history

  4. remove whitespace fixes to reduce PR confusion

    @mikealfare
    mikealfare committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    0efc5a4 View commit details
    Browse the repository at this point in the history

  5. remove whitespace fixes to reduce PR confusion

    @mikealfare
    mikealfare committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    0e5c614 View commit details
    Browse the repository at this point in the history