-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding in unique_key as a list for incremental models #291
Conversation
…ake version of possible spark answer to unique keys as a list still researching spark some.
Removing myself from review — feel free to add me back / ping me directly if you have specific questions while working through this! |
…f integration tests to cover each connection type.
I tried adding in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be fine with merging as is. I think if you played around with the date fields just a touch more, you could get the other tests working, tbh -- at least that's what I gathered from the circleci docs (the main error was the string to date conversion errors). That way, you could also test against the other endpoint. But I don't think it's that necessary since would the behavior really be that different? Probably not.
Date issues found only failing test is unrelated looking into it currently. |
@McKnight-42 I think the only remaining failing test is the one I've got a fix for in #301 |
great catch, will review and re run tests against |
### Description Ports tests for "unique_key as a list" from dbt-labs/dbt-spark#291.
resolves # CT-134
Description
adding spark implementation of dbt-core recent addition to accept lists as a unique key for incremental models see #4618
Checklist
CHANGELOG.md
and added information about my change to the "dbt-spark next" section.