fix: Do not require alias to avoid duplicate aliasing with --empty
#1162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1098
docs N/A
Problem
When running a dry run via
--empty
, dbt would duplicate any model aliases, causing the query to fail due to invalid syntax.Solution
This PR adopts the approaches taken in other adapters that do not require aliasing. Namely, it overrides the default
True
value forrequire_alias
, setting it toFalse
. As a result, when dbt creates dynamic SQL for dry runs, it does not inject additional aliasing. Thus, if a reference uses an alias, it keeps it as is. If not, it does not inject anything.I also imported the
BaseTestEmptyInlineSourceRef
fromdbt-adapters
to run those additional tests. Please let me know if you'd like to see additional testing done for this PR!Checklist