Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/http odbc conn extra #1092

Closed
wants to merge 2 commits into from

Conversation

jpoley
Copy link

@jpoley jpoley commented Aug 27, 2024

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

with existing http method for spark connections we are unable to pass custom odbc properties such as username / password instead of token and two way tls options.

Solution

provide an additional parameter called connection_str_extra allowing users to provide custom odbc connection properties.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@jpoley jpoley requested a review from a team as a code owner August 27, 2024 17:28
@cla-bot cla-bot bot added the cla:yes label Aug 27, 2024
@amychen1776 amychen1776 added needs_spike for when more research is needed enhancement New feature or request labels Aug 29, 2024
@colin-rogers-dbt
Copy link
Contributor

This is a great start, will follow up in #1093 to get it over the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes enhancement New feature or request needs_spike for when more research is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants