Base 207/add test #1057
Merged
Base 207/add test #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VersusFacit
added
Skip Changelog
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
VersusFacit
commented
Jun 25, 2024
dev-requirements.txt
Outdated
| @@ -2,8 +2,8 @@ | |||
| # TODO: how to automate switching from develop to version branches? | |||
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core | |||
| git+https://github.com/dbt-labs/dbt-common.git | |||
| git+https://github.com/dbt-labs/dbt-adapters.git | |||
| git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter | |||
| git+https://github.com/dbt-labs/dbt-adapters.git@ADAP-207/get_show_sql_has_no_wrapping | |||
There was a problem hiding this comment.
To be changed back before merge
VersusFacit
force-pushed
the
BASE-207/add_test
branch
2 times, most recently
from
fc0d543
to
b610664
Compare
VersusFacit
force-pushed
the
BASE-207/add_test
branch
from
b610664
to
5d87a88
Compare
mikealfare
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followon from Base Adapter #207
Problem
We should be testing for this!
Solution
Add the test.
Checklist