Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip broken tests, link to the issue for resolution #1056

Merged
merged 1 commit into from
Jun 21, 2024
Merged

skip broken tests, link to the issue for resolution #1056

merged 1 commit into from
Jun 21, 2024

Conversation

mikealfare
Copy link
Contributor

resolves #1054

Problem

Two tests are broken due to dependencies in the Databricks cluster.

Solution

Skip them for now and link to the resolution issue.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jun 21, 2024
@mikealfare mikealfare requested a review from a team as a code owner June 21, 2024 20:13
@cla-bot cla-bot bot added the cla:yes label Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jun 21, 2024
McKnight-42
McKnight-42 reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, like using the issue as a pointer message in the skip

@mikealfare mikealfare merged commit ba5b3f0 into main Jun 21, 2024
28 of 30 checks passed
@mikealfare mikealfare deleted the skip-broken-tests branch June 21, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 left review comments

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tech Debt] Update configuration on Databricks tests
3 participants
@mikealfare @McKnight-42 @colin-rogers-dbt