Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for date_spine macro, and sub macros #787

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Add tests for date_spine macro, and sub macros #787

merged 2 commits into from
Oct 10, 2023

Conversation

QMalcolm
Copy link
Contributor

resolves dbt-labs/dbt-core#8172

Problem

In dbt-labs/dbt-core#8172 we moved the date_spine macro and sub macros from dbt-utils to dbt-core. As such we should begin testing these macros to ensure they work properly on this adapter.

Solution

Begin running the tests for the date_spine macro and sub macros

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Sep 25, 2023
@QMalcolm QMalcolm requested a review from a team as a code owner September 25, 2023 19:51
@cla-bot cla-bot bot added the cla:yes label Sep 25, 2023
@mikealfare mikealfare enabled auto-merge (squash) October 10, 2023 23:21
@mikealfare mikealfare merged commit 273694b into main Oct 10, 2023
25 checks passed
@mikealfare mikealfare deleted the qmalcolm--date-spine-utils-testing branch October 10, 2023 23:52
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
@QMalcolm @mikealfare @philippe-boyd-maxa
Add tests for date_spine macro, and sub macros (dbt-labs#787)
a63399c 
Co-authored-by: Mike Alfare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42 McKnight-42 is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2855] [Feature] dbt_utils.date_spine should be added to core given new MetricFlow requirements
2 participants
@QMalcolm @mikealfare