Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove broken flake8 #778

Merged
merged 2 commits into from
Sep 18, 2023
Merged

remove broken flake8 #778

merged 2 commits into from
Sep 18, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 18, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

McKnight-42
McKnight-42 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This the cause of the alert? good catch

@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Sep 18, 2023
@nathaniel-may nathaniel-may merged commit abbd59b into 1.0.latest Sep 18, 2023
16 checks passed
@nathaniel-may nathaniel-may deleted the removeFlake8From1_0 branch September 18, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-rogers-dbt @McKnight-42 @nathaniel-may