Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow testing against any core branch #771

Merged
merged 3 commits into from
Sep 19, 2023
Merged

allow testing against any core branch #771

merged 3 commits into from
Sep 19, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner September 14, 2023 01:02
@cla-bot cla-bot bot added the cla:yes label Sep 14, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

QMalcolm
QMalcolm approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Looks like the actions are complaining that it doesn't have a changie entry. I don't think this needs to be included in the release notes, so doesn't need a changie entry.

@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Sep 15, 2023
@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) September 15, 2023 23:49
@colin-rogers-dbt colin-rogers-dbt merged commit 82b2acb into main Sep 19, 2023
23 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the testAnyCoreBranch branch September 19, 2023 19:56
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
@colin-rogers-dbt @philippe-boyd-maxa
allow testing against any core branch (dbt-labs#771)
641c7f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@QMalcolm QMalcolm QMalcolm approved these changes

@Fleid Fleid Awaiting requested review from Fleid Fleid is a code owner automatically assigned from dbt-labs/adapters

@emmyoop emmyoop Awaiting requested review from emmyoop

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-rogers-dbt @QMalcolm @mikealfare