Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update expected values #763

Merged
merged 36 commits into from
Sep 11, 2023
Merged

update expected values #763

merged 36 commits into from
Sep 11, 2023

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Sep 7, 2023

resolves #762
docs dbt-labs/docs.getdbt.com/#

Problem

change to agate_helper in core requires update to data type expected value in test

Solution

merge into main and backport to 1.6.latest when core does

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Sep 7, 2023
@McKnight-42 McKnight-42 requested a review from a team as a code owner September 7, 2023 20:27
@cla-bot cla-bot bot added the cla:yes label Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@colin-rogers-dbt colin-rogers-dbt merged commit a67838d into main Sep 11, 2023
24 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the McKnight-42/ADAP-876 branch September 11, 2023 16:41
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
* update RELEASE_BRANCH env

* push up fix to core change in agate_helper

* add changelog

(cherry picked from commit a67838d)
colin-rogers-dbt pushed a commit that referenced this pull request Sep 11, 2023
* update RELEASE_BRANCH env

* push up fix to core change in agate_helper

* add changelog

(cherry picked from commit a67838d)

Co-authored-by: Matthew McKnight <[email protected]>
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
* update RELEASE_BRANCH env

* push up fix to core change in agate_helper

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-876] [Bug] Updating agate_helper in core requires update in of data type in some tests
2 participants