Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-821: Refactor prep for dynamic table / table/view swap #751

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

mikealfare
Copy link
Contributor

Problem

We need to support swapping dynamic tables for tables/views and vice versa. This requires replace functionality that crosses relation types and references create, rename, and drop macros in multiple scenarios. Restructuring the macros files would make it easier to understand how all of the pieces interact. However, changing a lot of files in a single PR makes the PR itself difficult to understand.

Solution

This PR will only perform restructuring changes. Macros are moved around, macro files are broken apart; however, macro names, signatures, and code does not change. As a result, no tests are needed either.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare requested a review from a team as a code owner August 22, 2023 03:18
@mikealfare mikealfare self-assigned this Aug 22, 2023
@cla-bot cla-bot bot added the cla:yes label Aug 22, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare removed the request for review from nathaniel-may August 25, 2023 22:02
@mikealfare mikealfare merged commit 8d5fca9 into main Aug 28, 2023
24 checks passed
@mikealfare mikealfare deleted the feature/dynamic-tables/adap-821-prep branch August 28, 2023 17:42
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
…#751)

* restructure macros directory, create separate files and directories for each ddl statement and relation type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants