Remove legacy time spine warning message #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevonFulcher
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
courtneyholcomb
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Looks good - note that we'll need to release a new production version in order to ship this to core. That process is documented here https://www.notion.so/dbtlabs/DSI-Build-Release-Process-48d94828e8b840abb8529f7501fb2c5b?pvs=4
| ) | ||
| issues = validator.validate_semantic_manifest(semantic_manifest) | ||
| assert not issues.has_blocking_issues | ||
| assert len(issues.warnings) == 1 |
There was a problem hiding this comment.
Could keep this test but update this to say assert len(issues.warnings) == 1 and remove the line below!
There was a problem hiding this comment.
I assume you mean assert len(issues.warnings) == 0, right?
|
Actually, we shouldn't do the production release until after code freeze, since mantle could pick up the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # SL-2934
Description
This PR removes the legacy time spine configuration warning in order to make the warning appear in dbt-core as a behavior change instead.
Checklist
changie newto create a changelog entry