Remove legacy time spine warning

dbt-labs · Oct 7, 2024 · 7d1e788 · 7d1e788
1 parent 3033a83
commit 7d1e788
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 47 deletions.
diff --git a/dbt_semantic_interfaces/validations/time_spines.py b/dbt_semantic_interfaces/validations/time_spines.py
@@ -28,23 +28,10 @@ def validate_manifest(semantic_manifest: SemanticManifestT) -> Sequence[Validati
         if not semantic_manifest.semantic_models:
             return issues
 
-        time_spines = semantic_manifest.project_configuration.time_spines
-        if not time_spines:
-            docs_message = "See documentation to configure: https://docs.getdbt.com/docs/build/metricflow-time-spine"
-            # If they have the old time spine configured and need to migrate
-            if semantic_manifest.project_configuration.time_spine_table_configurations:
-                issues.append(
-                    ValidationWarning(
-                        message="Time spines without YAML configuration are in the process of deprecation. Please add "
-                        "YAML configuration for your 'metricflow_time_spine' model. " + docs_message
-                    )
-                )
-            return issues
-
         # Verify that there is only one time spine per granularity
         time_spines_by_granularity: Dict[TimeGranularity, List[TimeSpine]] = {}
         granularities_with_multiple_time_spines: Set[TimeGranularity] = set()
-        for time_spine in time_spines:
+        for time_spine in semantic_manifest.project_configuration.time_spines:
             granularity = time_spine.primary_column.time_granularity
             if granularity in time_spines_by_granularity:
                 time_spines_by_granularity[granularity].append(time_spine)

diff --git a/tests/validations/test_time_spines.py b/tests/validations/test_time_spines.py
@@ -12,7 +12,6 @@
 from dbt_semantic_interfaces.implementations.node_relation import PydanticNodeRelation
 from dbt_semantic_interfaces.implementations.project_configuration import (
     PydanticProjectConfiguration,
-    PydanticTimeSpineTableConfiguration,
 )
 from dbt_semantic_interfaces.implementations.semantic_manifest import (
     PydanticSemanticManifest,
@@ -75,38 +74,6 @@ def test_valid_time_spines() -> None:  # noqa: D
     SemanticManifestValidator[PydanticSemanticManifest]().checked_validations(semantic_manifest)
 
 
-def test_only_legacy_time_spine() -> None:  # noqa: D
-    validator = SemanticManifestValidator[PydanticSemanticManifest]()
-    semantic_manifest = PydanticSemanticManifest(
-        semantic_models=[
-            semantic_model_with_guaranteed_meta(
-                name="sum_measure",
-                measures=[
-                    PydanticMeasure(name="foo", agg=AggregationType.SUM, agg_time_dimension="dim", create_metric=True)
-                ],
-                dimensions=[
-                    PydanticDimension(
-                        name="dim",
-                        type=DimensionType.TIME,
-                        type_params=PydanticDimensionTypeParams(time_granularity=TimeGranularity.SECOND),
-                    )
-                ],
-                entities=[PydanticEntity(name="entity", type=EntityType.PRIMARY)],
-            ),
-        ],
-        metrics=[],
-        project_configuration=PydanticProjectConfiguration(
-            time_spine_table_configurations=[
-                PydanticTimeSpineTableConfiguration(location="hurrr", column_name="fun_col", grain=TimeGranularity.DAY)
-            ]
-        ),
-    )
-    issues = validator.validate_semantic_manifest(semantic_manifest)
-    assert not issues.has_blocking_issues
-    assert len(issues.warnings) == 1
-    assert "Time spines without YAML configuration are in the process of deprecation." in issues.warnings[0].message
-
-
 def test_duplicate_time_spine_granularity() -> None:  # noqa: D
     validator = SemanticManifestValidator[PydanticSemanticManifest]()
     semantic_manifest = PydanticSemanticManifest(