Adap 821/unit tests infer wrong datatype for None values in fixtures #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
VersusFacit
changed the title
mikealfare
reviewed
Jul 23, 2024
dev-requirements.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| # install latest changes in dbt-core + dbt-postgres | |||
| git+https://github.com/dbt-labs/dbt-adapters.git | |||
| git+https://github.com/dbt-labs/dbt-adapters.git@ADAP-821/support_for_redshift_821 | |||
There was a problem hiding this comment.
Friendly reminder to revert prior to merging.
mikealfare
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Approved, conditional on reverting dev-requirements.txt post merge of dbt-labs/dbt-adapters#270.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #821
Note this Pr depends on the base adapter PR here.
Problem
Take 2 in response to #860
Solution
Redshift provides a macro that will check for the bad row scenario and throw a more helpful error to the user than the existing type mismatch bug that caused this error in the first place.
Checklist