Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-878] update expected values #598

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

McKnight-42
Copy link
Contributor

resolves #597
docs dbt-labs/docs.getdbt.com/#

Problem

change to agate_helper in core requires an update to the data type expected value in the test.

This pr is dbt-redshift versions of earlier work we did but had to revert in dbt-bigquery see: dbt-labs/dbt-bigquery#890 and dbt-labs/dbt-bigquery#894

Solution

merge into main and backport to 1.6.latest when core does

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 requested a review from a team as a code owner September 8, 2023 16:33
@McKnight-42 McKnight-42 self-assigned this Sep 8, 2023
@cla-bot cla-bot bot added the cla:yes label Sep 8, 2023
@colin-rogers-dbt colin-rogers-dbt merged commit 4c5e49b into main Sep 11, 2023
30 of 31 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the mcknight/ADAP-878 branch September 11, 2023 16:41
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
colin-rogers-dbt pushed a commit that referenced this pull request Sep 11, 2023
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Oct 25, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-878] [Bug] Updating agate_helper in core requires update in of data type in some tests
2 participants