-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1519] Adding friendlier error message when dist is improperly set as a list or mapping #226
Open
dluftspring
wants to merge
15
commits into
dbt-labs:main
Choose a base branch
from
dluftspring:fix/224/distkey-error-message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cc80801
Adding friendlier error message when dist is improperly set as a list…
dluftspring 4a65af6
Commit changie file
dluftspring 06edc16
Merge branch 'main' into fix/224/distkey-error-message
Fleid 0b61ec1
Merge branch 'main' into fix/224/distkey-error-message
VersusFacit f3a0d74
Merge branch 'main' into fix/224/distkey-error-message
VersusFacit f739b54
fix syntax error
VersusFacit a8f4c89
Merge branch 'main' into fix/224/distkey-error-message
mikealfare 118ddf6
Merge branch 'main' into fix/224/distkey-error-message
mikealfare af3598e
Add missing do and fix type check to exclude strings
dluftspring 063656c
Merge branch 'main' into fix/224/distkey-error-message
dbeatty10 137c72b
Merge branch 'main' into fix/224/distkey-error-message
mikealfare 0e3dc8b
Merge branch 'main' into fix/224/distkey-error-message
mikealfare 8d4c3c3
Merge branch 'main' into fix/224/distkey-error-message
mikealfare 023c3ba
Merge branch 'main' into fix/224/distkey-error-message
dbeatty10 9ae7650
Merge branch 'main' into fix/224/distkey-error-message
dbeatty10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
kind: Fixes | ||
body: Friendlier error message for misspecified distkey type | ||
time: 2022-11-22T17:20:14.432522-08:00 | ||
custom: | ||
Author: dluftspring | ||
Issue: "224" | ||
PR: "226" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a
do
in front of it, e.g.:Alternatively, I think
{{
instead of{%
also works:Otherwise jinja is looking for a keyword like
set
,if
,macro
, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's my mistake on the compiler error- it needs a do statement. Let me update this later today. There's an issue with the conditional check. Strings are technically iterable so this isn't doing what I want it to do in any case