Skip to content

Commit

Permalink
Add explicit dependency on sqlparse that used to inherit from core (#728
Browse files Browse the repository at this point in the history
)

* add explicit dependency on sqlparse that used to inherit from core

* update build verification command

* remove core installation check since it is no longer installed
  • Loading branch information
mikealfare authored Mar 2, 2024
1 parent 05b7430 commit 8077150
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ jobs:
python -m pip --version
pre-commit --version
mypy --version
dbt --version
- name: pre-commit hooks
run: pre-commit run --all-files --show-diff-on-failure
Expand Down Expand Up @@ -204,12 +203,12 @@ jobs:
- name: Check wheel distributions
run: |
dbt --version
python -c "import dbt.adapters.redshift"
- name: Install source distributions
run: |
find ./dist/*.gz -maxdepth 1 -type f | xargs python -m pip install --force-reinstall --find-links=dist/
- name: Check source distributions
run: |
dbt --version
python -c "import dbt.adapters.redshift"
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ on:
package_test_command:
description: "Package test command"
type: string
default: "dbt --version"
default: "python -c \"import dbt.adapters.redshift\""
required: true
test_run:
description: "Test run (Publish release as draft)"
Expand Down Expand Up @@ -92,7 +92,7 @@ on:
package_test_command:
description: "Package test command"
type: string
default: "dbt --version"
default: "python -c \"import dbt.adapters.redshift\""
required: true
test_run:
description: "Test run (Publish release as draft)"
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def _plugin_version() -> str:
# Pin to the patch or minor version, and bump in each new minor version of dbt-redshift.
"redshift-connector<=2.0.918, >=2.0.913, !=2.0.914",
# installed via dbt-core but referenced directly; don't pin to avoid version conflicts with dbt-core
"sqlparse>=0.2.3,<0.5",
"agate",
],
zip_safe=False,
Expand Down

0 comments on commit 8077150

Please sign in to comment.