Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker release to the full release process for final releases #51

Merged
merged 50 commits into from
May 20, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 5, 2024

Problem

Publishing a Docker release is currently a manual process which can be forgotten.

Solution

Add the Docker release to the release pipeline.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 5, 2024
@wiz-inc-266a8a9c32
Copy link

wiz-inc-266a8a9c32 bot commented Apr 5, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 2H 1M 0L 1I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 2H 1M 0L 1I
Secrets 0🔑

@mikealfare mikealfare linked an issue Apr 10, 2024 that may be closed by this pull request
3 tasks
@mikealfare mikealfare marked this pull request as ready for review April 13, 2024 03:31
@mikealfare
Copy link
Contributor Author

Converting to draft until the full release workflow is resolved. We're missing the GH portion, on which Docker is dependent.

@mikealfare mikealfare marked this pull request as ready for review May 15, 2024 01:34
@mikealfare mikealfare requested a review from a team as a code owner May 15, 2024 01:34
docker/test.sh Outdated Show resolved Hide resolved
docker/test.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review times

@VersusFacit VersusFacit self-requested a review May 20, 2024 21:07
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it :shipit:

@mikealfare mikealfare merged commit e308e2a into main May 20, 2024
18 checks passed
@mikealfare mikealfare deleted the config/docker-release branch May 20, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Automate Docker Release
3 participants