Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate tests that should exist in dbt-core #166

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

These are more duplicate tests that should live in dbt-core. They were found in, and removed from, 1.8.

Solution

Remove them here too.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Oct 17, 2024
@mikealfare mikealfare requested a review from a team as a code owner October 17, 2024 21:44
@cla-bot cla-bot bot added the cla:yes label Oct 17, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-postgres contributing guide.

@mikealfare mikealfare enabled auto-merge (squash) October 17, 2024 21:46
@mikealfare mikealfare merged commit 80483a0 into main Oct 18, 2024
17 of 19 checks passed
@mikealfare mikealfare deleted the remove-duplicate-tests branch October 18, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants