Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tests covered by dbt-core #147

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 9, 2024

resolves #N/A
docs dbt-labs/docs.getdbt.com/#

Problem

From testing in https://github.com/dbt-labs/dbt-postgres/actions/runs/10775130606:

tests/functional/adapter/test_debug.py: 8 warnings
tests/functional/adapter/test_empty.py: 1 warning
tests/functional/minimal_cli/test_minimal_cli.py: 3 warnings
tests/functional/test_dbt_runner.py: 5 warnings
tests/functional/test_init.py: 5 warnings
tests/functional/test_multiple_indexes.py: 1 warning
...
tests/functional/deprecations/test_config_deprecations.py FFFFF....      [ 38%]

Solution

tests/functional/adapter/test_debug.py -> actually an adapter test
tests/functional/adapter/test_empty.py -> actually an adapter test
tests/functional/minimal_cli/test_minimal_cli.py -> should exclusively be a dbt-core test
tests/functional/test_dbt_runner.py -> should exclusively be a dbt-core test
tests/functional/test_init.py -> should exclusively be a dbt-core test (don't even think an adapter gets loaded for this one)
tests/functional/test_multiple_indexes.py -> dbt-postgres specific test
tests/functional/deprecations/test_config_deprecations.py -> should be dbt-core only, and drift introduced in dbt-labs/dbt-core#10670

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-postgres contributing guide.

@MichelleArk MichelleArk marked this pull request as ready for review September 9, 2024 15:10
@MichelleArk MichelleArk requested a review from a team as a code owner September 9, 2024 15:10
@MichelleArk MichelleArk merged commit 6e4a8e3 into main Sep 9, 2024
23 of 24 checks passed
@MichelleArk MichelleArk deleted the remove-extraneous-tests branch September 9, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants