-
Notifications
You must be signed in to change notification settings - Fork 116
Use cookiecutter and delete irrelevant code #32
base: master
Are you sure you want to change the base?
Conversation
c0e32b0
to
067ba45
Compare
tried running per new installation instructions, after
let me know if I'm missing something obvious? |
Oh yah, you'd need to run it from the branch!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok — this is cool, even kinda fun
small things:
- do you feel strongly about
name
,project_name
,profile_name
, andclient_name
being separate inputs? I feel like I'd be happy with one consistent name. only downside is thatproject_name
has to be snake case, and I know we both like our dir + repo names to be kebab case require-dbt-version
is set to v0.16.0, should upgrade. is there a sane way to make this dynamic?- should probably remove future grants from our Snowflake grants macro
cool idea for future:
- an input for connection method, based on their selected database (is this kind of pathing possible with cookiecutter?)
Overall thoughtsThis was a super fun project to work on as I was looking to learn some more python, but I don't think we've really used it that much as a team, or externally. I think eventually I'd like to see some of this logic moved into the real Answering your questions(with that in mind)
One thing to note: I think I originally had separate inputs because I found the resultant templates easier to read: I think I will rationalize the existing variables:
To this instead:
(and update the templates where required)
We could make that an input, but then there's all the other changes that come with a version upgrade, that would be hard to capture in a template (e.g. config-version, nesting of vars). IMO we should simply do regular upgrades to the repo if it's a thing we want to keep alive :)
Yup, I might do another comb through of code — incidentally I also removed the Redshift warehouse maintenance macros.
Hmm I'm not sure if it's possible — my initial search (and tinkering) indicates it's not. I think we'll simply have to err on the side of being less-clever here and maybe throw in some links to docs in various places |
that all makes sense! I got excited playing around with this / cookiecutter for the first time; I think you've got the right balance of effort + impact. |
Was working on a Discourse article to pair with a Coalesce talk, went to use this tool to quickly create a repo in
labs
, got annoyed with it, updated it to use the cookiecutter framework rather than use my custom code 😅