-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fnMatch to group selectors #9812
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9812 +/- ##
==========================================
- Coverage 88.10% 88.07% -0.04%
==========================================
Files 178 178
Lines 22458 22459 +1
==========================================
- Hits 19786 19780 -6
- Misses 2672 2679 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
resolves #9811
Problem
Groups with spaces in them cannot be selected, since spaces and commas are used as set operation delimiters in selector syntax.
Solution
This simple solution makes the group selector more similar to other selectors, and is a small additive change to the group method.
Checklist