Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fnMatch to group selectors #9812

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Add fnMatch to group selectors #9812

merged 5 commits into from
Apr 3, 2024

Conversation

heysweet
Copy link
Contributor

@heysweet heysweet commented Mar 24, 2024

resolves #9811

Problem

Groups with spaces in them cannot be selected, since spaces and commas are used as set operation delimiters in selector syntax.

Solution

This simple solution makes the group selector more similar to other selectors, and is a small additive change to the group method.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@heysweet heysweet requested a review from a team as a code owner March 24, 2024 00:08
@cla-bot cla-bot bot added the cla:yes label Mar 24, 2024
@heysweet heysweet requested a review from dbeatty10 March 24, 2024 00:09
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (71f3519) to head (ef6454b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9812      +/-   ##
==========================================
- Coverage   88.10%   88.07%   -0.04%     
==========================================
  Files         178      178              
  Lines       22458    22459       +1     
==========================================
- Hits        19786    19780       -6     
- Misses       2672     2679       +7     
Flag Coverage Δ
integration 85.43% <100.00%> (-0.11%) ⬇️
unit 61.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as draft March 26, 2024 00:28
@emmyoop emmyoop marked this pull request as ready for review March 26, 2024 00:29
@github-actions github-actions bot added the community This PR is from a community member label Mar 26, 2024
@MichelleArk MichelleArk merged commit a994ace into main Apr 3, 2024
62 checks passed
@MichelleArk MichelleArk deleted the asweet/group-fn-match branch April 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add fnMatch (Wildcard support) to group selectors
3 participants