Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update triggers to use issues for opening docs issues #9803

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 22, 2024

resolves dbt-labs/actions#162

Problem

PRs have to get labeled when we're already labeling the issues. Some PRs never make it to getting docs PRs created.

Solution

Trigger docs issues to be created when an issue has the user_docs label and is closed as completed.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner March 22, 2024 17:24
@cla-bot cla-bot bot added the cla:yes label Mar 22, 2024
@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Mar 22, 2024
@emmyoop emmyoop changed the title update triggers to use issues for openeing docs issues update triggers to use issues for opening docs issues Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (b435e26) to head (f6b3e35).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9803      +/-   ##
==========================================
- Coverage   88.04%   88.02%   -0.02%     
==========================================
  Files         178      178              
  Lines       22461    22461              
==========================================
- Hits        19776    19772       -4     
- Misses       2685     2689       +4     
Flag Coverage Δ
integration 85.41% <ø> (-0.02%) ⬇️
unit 61.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop requested a review from QMalcolm March 22, 2024 17:57
@emmyoop
Copy link
Member Author

emmyoop commented Mar 22, 2024

The failing CI is unrelated to this PR and not blocking.

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this, it's gonna make life easier 🙂

A few typos in comments me maybe want to handle though

.github/workflows/docs-issue.yml Outdated Show resolved Hide resolved
.github/workflows/docs-issue.yml Outdated Show resolved Hide resolved
@emmyoop emmyoop merged commit 68970d0 into main Mar 22, 2024
56 checks passed
@emmyoop emmyoop deleted the er/trigger-docs-on-issues branch March 22, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create issues in docs.getdbt.com off os issues instead of PRs
2 participants