-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9608: Unit test path outputs #9793
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9793 +/- ##
==========================================
- Coverage 88.07% 88.04% -0.04%
==========================================
Files 178 178
Lines 22461 22457 -4
==========================================
- Hits 19783 19772 -11
- Misses 2678 2685 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup in the unit test parser. Looks good.
resolves #9608
Problem
Solution
This PR makes the following changes:
target/compiled/my_model.yml/model_a.sql
to prevent overwriting model attarget/compiled/model_a.sql
.RunResult
out ofUnitTestNode
instead ofUnitTestDefinition
since the latter doesn't have path information.TestUnitTestDuplicateTestNamesAcrossModels
to check forunique_ids
instead of model names inresults
Checklist