Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 6444 grant username quotes #8787

Closed
wants to merge 5 commits into from
Closed

Issue 6444 grant username quotes #8787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3cab45e
add adapter quote
Oct 6, 2023
ee1c72b
Update default__get_grant_sql
Oct 6, 2023
00d1d4e
update changelog
barton996 Oct 6, 2023
f4b0cf6
trigger CI
barton996 Oct 6, 2023
5196d88
remove period
barton996 Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20231006-141430.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: 'Add quotes to usernames when revoking and granting permissions. Resolves issues
#6444 and #8751'
time: 2023-10-06T14:14:30.472821+01:00
custom:
Author: barton996
Issue: 6444 8751
12 changes: 10 additions & 2 deletions core/dbt/include/global_project/macros/adapters/apply_grants.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@
{% endmacro %}

{%- macro default__get_grant_sql(relation, privilege, grantees) -%}
grant {{ privilege }} on {{ relation }} to {{ grantees | join(', ') }}
grant {{ privilege }} on {{ relation }} to
{% for grantee in grantees %}
{{ adapter.quote(grantee) }}
{% if not loop.last %},{% endif %}
{% endfor %}
{%- endmacro -%}


Expand All @@ -79,7 +83,11 @@
{% endmacro %}

{%- macro default__get_revoke_sql(relation, privilege, grantees) -%}
revoke {{ privilege }} on {{ relation }} from {{ grantees | join(', ') }}
revoke {{ privilege }} on {{ relation }} from
{% for grantee in grantees %}
{{ adapter.quote(grantee) }}
{% if not loop.last %},{% endif %}
{% endfor %}
{%- endmacro -%}


Expand Down