-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit test config #8565
unit test config #8565
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## unit_testing_feature_branch #8565 +/- ##
================================================================
+ Coverage 76.09% 86.72% +10.63%
================================================================
Files 176 176
Lines 25962 26002 +40
================================================================
+ Hits 19755 22551 +2796
+ Misses 6207 3451 -2756
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I'm seeing the same core/dbt/context/providers.py:1507: error: Argument 1 to "contextmember" has incompatible type "Callable[[UnitTestContext, str, Optional[str]], str]"; expected "Optional[str]" [arg-type] @gshank - any idea what the cause is? I think we could review this PR independently and look to resolve the mypy issue in a follow-up |
That mypy error for contextmember was also seen in a mypy pr that Quigley did. Let me merge main into the feature branch... |
Oh, I think '@contextmember' needs to be changed to '@contextmember()' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I suspect we'd get schema changes if we ran the script to build it though. We don't have any artifact tests for unit tests, which is why there are no test failures.
good point! I updated manifest/v11.json in this commit so we can keep track of where the changes were necessary but won't backfill the artifact tests as this PR is already getting pretty big. |
@dbt-labs/cloud-artifacts - these changes going onto a feature branch so don't need review quite yet as they will not be released until the feature branch is merged (which will tag the CA team for review at that point) |
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4062 |
* Initial implementation of unit testing (from pr #2911) Co-authored-by: Michelle Ark <[email protected]> * 8295 unit testing artifacts (#8477) * unit test config: tags & meta (#8565) * Add additional functional test for unit testing selection, artifacts, etc (#8639) * Enable inline csv format in unit testing (#8743) * Support unit testing incremental models (#8891) * update unit test key: unit -> unit-tests (#8988) * convert to use unit test name at top level key (#8966) * csv file fixtures (#9044) * Unit test support for `state:modified` and `--defer` (#9032) Co-authored-by: Michelle Ark <[email protected]> * Allow use of sources as unit testing inputs (#9059) * Use daff for diff formatting in unit testing (#8984) * Fix #8652: Use seed file from disk for unit testing if rows not specified in YAML config (#9064) Co-authored-by: Michelle Ark <[email protected]> Fix #8652: Use seed value if rows not specified * Move unit testing to test and build commands (#9108) * Enable unit testing in non-root packages (#9184) * convert test to data_test (#9201) * Make fixtures files full-fledged members of manifest and enable partial parsing (#9225) * In build command run unit tests before models (#9273) --------- Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Emily Rockman <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Kshitij Aranke <[email protected]>
resolves #8294
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist