-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ct 2599/childrens parents depth #8379
base: main
Are you sure you want to change the base?
Conversation
This commit is a bit premature because some of the requested functionality in #7703 doesn't quite work.
Using both That means we can't specify the depth of the children (denoted with |
@kentkr hey do you mind resolving these merge conflicts so that we can take a look? |
Hey! Yep thanks for getting back to me. I fixed the merge conflicts. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8379 +/- ##
==========================================
- Coverage 89.17% 86.39% -2.78%
==========================================
Files 183 183
Lines 23491 23553 +62
==========================================
- Hits 20947 20348 -599
- Misses 2544 3205 +661
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
@dbeatty10 thanks for jumping in on this! Let me know if you need anything else from me. |
resolves #7703
Problem
This feature adds the ability to specify the maximum childs parent depth like
1@model
. It functions similarly to1+model
.Solution
A more thorough discussion can be found in #7703. The solution was to add to existing functionality like spec parsing and child/parent depth restrictions when creating the DAG.
Checklist