Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tidy-First] Refactor safe run hooks #10944

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Tidy-First] Refactor safe run hooks #10944

wants to merge 6 commits into from

Commits on Oct 30, 2024

  1. Remove failed tracking in safe_run_hooks as it's duplicative of `… 

    …status`
    @QMalcolm
    QMalcolm committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c63dd9d View commit details
    Browse the repository at this point in the history

  2. Delay calculation of failures in safe_run_hooks to simplify code 

    If it isn't apparent, I'm trying to reduce the need for tracking variables
to make it easier extract the execution code to a separate private function
to make it easier to see what is happening.
    @QMalcolm
    QMalcolm committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    43945d6 View commit details
    Browse the repository at this point in the history

  3. Lint safe_run_hooks function signature

    @QMalcolm
    QMalcolm committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    de43f59 View commit details
    Browse the repository at this point in the history

  4. Refactor safe_run_hooks so that there is only one return statement

    @QMalcolm
    QMalcolm committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    43d1720 View commit details
    Browse the repository at this point in the history

  5. Split out actual execution of hook into private function to simplify … 

    …`safe_run_hooks`
    @QMalcolm
    QMalcolm committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9731eaa View commit details
    Browse the repository at this point in the history

  6. Fix indentation of _safe_run_hook 

    In 9731eaa when splitting out the hook execution logic I screwed up
the indentation of most of the logic 🙈 This fixes that
    @QMalcolm
    QMalcolm committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6358aff View commit details
    Browse the repository at this point in the history