-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude hook results from results in on-run-end context #10885
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
@graciegoheen We should backport this to 1.9 since this and the previous change to hook behavior should be shipped together. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10885 +/- ##
==========================================
- Coverage 89.18% 89.15% -0.03%
==========================================
Files 183 183
Lines 23443 23443
==========================================
- Hits 20908 20901 -7
- Misses 2535 2542 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Looks good. |
7358dbb
to
7e0f572
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.9.latest 1.9.latest
# Navigate to the new working tree
cd .worktrees/backport-1.9.latest
# Create a new branch
git switch --create backport-10885-to-1.9.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a0674db8400673d7dd4ebf7597dd82b3349337ce
# Push it to GitHub
git push --set-upstream origin backport-10885-to-1.9.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.9.latest Then, create a pull request where the |
* exclude hook results from results in on-run-end context * changelog * preserve previous behavior
This brings the results in on-run-end back to before https://github.com/dbt-labs/dbt-core/pull/10699/files was introduced.
We can introduce this behind a behavior flag as needed later on.
Problem
Solution
Checklist