Add adapter telemetry to snowplow event. #10859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10859 +/- ##
==========================================
- Coverage 89.15% 86.46% -2.70%
==========================================
Files 183 183
Lines 23443 23469 +26
==========================================
- Hits 20901 20292 -609
- Misses 2542 3177 +635
Flags with carried forward coverage won't be shown. Click here to find out more.
|
VersusFacit
commented
Oct 16, 2024
VersusFacit
commented
Oct 18, 2024
VersusFacit
commented
Oct 18, 2024
core/dbt/task/run.py
Outdated
| @@ -133,6 +139,7 @@ def track_model_run(index, num_nodes, run_model_result): | |||
| "contract_enforced": contract_enforced, | |||
| "access": access, | |||
| "versioned": versioned, | |||
| "adapter_info": asdict(adapter_info), | |||
There was a problem hiding this comment.
I considered that this should be something JSON safe, which a Python dict is 🫡
mikealfare
reviewed
Oct 21, 2024
peterallenwebb
approved these changes
Oct 28, 2024
QMalcolm
added a commit
that referenced
this pull request
Oct 30, 2024
In #10859 we started using the `get_adapter_run_info` method provided by `dbt-adapters`. However that function is only available in dbt-adapters >= 1.8.0. Thus 1.8.0 is our new minimum for dbt-adapters.
5 tasks
QMalcolm
added a commit
that referenced
this pull request
Oct 30, 2024
* Bump minimum dbt-adpaters to 1.8.0 In #10859 we started using the `get_adapter_run_info` method provided by `dbt-adapters`. However that function is only available in dbt-adapters >= 1.8.0. Thus 1.8.0 is our new minimum for dbt-adapters. * Add changie doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dbt-labs/dbt-adapters#301
Solution
We propose exposing a method on the base adapter that will use existing snowplow infrastructure for tracking user statistics for any adapter.
We designed the json schema and event data to make it easy for us to add additional per-adapter information as use-cases emerge.
Checklist