Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External catalog config #10814

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

External catalog config #10814

wants to merge 7 commits into from

Conversation

colin-rogers-dbt
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.12%. Comparing base (a86e2b4) to head (706ff32).
Report is 8 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a86e2b4) and HEAD (706ff32). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (a86e2b4) HEAD (706ff32)
unit 2 1
integration 10 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main   #10814       +/-   ##
===========================================
- Coverage   89.17%   62.12%   -27.05%     
===========================================
  Files         183      184        +1     
  Lines       23382    23430       +48     
===========================================
- Hits        20850    14557     -6293     
- Misses       2532     8873     +6341
Flag Coverage Δ
integration ?
unit 62.12% <80.64%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.12% <80.64%> (-0.06%) ⬇️
Integration Tests 62.12% <80.64%> (-27.05%) ⬇️

colin-rogers-dbt
colin-rogers-dbt commented Oct 21, 2024
View reviewed changes
core/dbt/contracts/graph/manifest.py
identifier = f"{target_source_name}.{target_table_name}"
catalog_database = catalog.configuration.internal_namespace.database
catalog_schema = catalog.configuration.internal_namespace.schema_
return SourceDefinition(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add merge functionality to merge with sources.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move down to below if disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colin-rogers-dbt