-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9005: Allow singular tests to be documented in properties.yml
#10744
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10744 +/- ##
==========================================
- Coverage 88.97% 88.96% -0.01%
==========================================
Files 181 181
Lines 22956 23019 +63
==========================================
+ Hits 20424 20478 +54
- Misses 2532 2541 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
properties.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Resolves #9005
Problem
Singular tests cannot be documented in YAML.
Solution
SingularTestPatchParser
to parse patches for singular tests under thedata_tests
key inproperties.yml
description
via doc block,error_if
andmeta
work as expectedproperties.yml
can be defined in the test pathChecklist