Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template for docs issues #10731

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Update template for docs issues #10731

merged 4 commits into from
Sep 18, 2024

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Sep 17, 2024

Description

Update template for auto-creating Docs Issues to include:

  • Link to originating issue (ie the one that's using the user_docs label
  • Add label dbt-core v1.9 -- this should be updated / incremented at the end/start of the next version

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@nghi-ly nghi-ly requested a review from a team as a code owner September 17, 2024 21:02
Copy link

cla-bot bot commented Sep 17, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @nghi-ly

@github-actions github-actions bot added the community This PR is from a community member label Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (c6b8f7e) to head (bab7cee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10731      +/-   ##
==========================================
+ Coverage   88.90%   88.95%   +0.05%     
==========================================
  Files         180      181       +1     
  Lines       22856    22959     +103     
==========================================
+ Hits        20319    20424     +105     
+ Misses       2537     2535       -2     
Flag Coverage Δ
integration 86.14% <ø> (+0.04%) ⬆️
unit 62.37% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.37% <ø> (-0.06%) ⬇️
Integration Tests 86.14% <ø> (+0.04%) ⬆️

Copy link

cla-bot bot commented Sep 17, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @nghi-ly

Copy link

cla-bot bot commented Sep 17, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @nghi-ly

@nghi-ly
Copy link
Contributor Author

nghi-ly commented Sep 17, 2024

hmm, i did sign and submit the CLA. not sure why i'm still getting this error #10731 (comment)

Screenshot 2024-09-17 at 3 01 30 PM

@@ -37,5 +37,6 @@ jobs:
with:
issue_repository: "dbt-labs/docs.getdbt.com"
issue_title: "[Core] Docs Changes Needed from ${{ github.event.repository.name }} Issue #${{ github.event.issue.number }}"
issue_body: "At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated."
issue_body: "At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.\n Originating from this issue: https://github.com/dbt-labs/dbt-core/issues/${{ github.event.issue.number }}"
label: 'dbt-core v1.9'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're opening an issue in another repo we can't actually add any labels. The community-label.yml workflow works entirely within the core repo which is why it can add labels to issues.

Right now you're adding labels to these autogenerated issues within your own repo with autogenerated_labeler.yml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see. thank you for the info and extra context

Copy link

cla-bot bot commented Sep 18, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @nghi-ly

@nghi-ly nghi-ly requested review from emmyoop and a team September 18, 2024 17:17
@emmyoop
Copy link
Member

emmyoop commented Sep 18, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Sep 18, 2024
Copy link

cla-bot bot commented Sep 18, 2024

The cla-bot has been summoned, and re-checked this pull request!

@emmyoop emmyoop merged commit 4c326e4 into main Sep 18, 2024
61 checks passed
@emmyoop emmyoop deleted the ly-docs-labels branch September 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants