-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace TestSelector
with ResourceTypeSelector
#10718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10718 +/- ##
==========================================
- Coverage 88.88% 88.88% -0.01%
==========================================
Files 180 180
Lines 22856 22851 -5
==========================================
- Hits 20316 20311 -5
Misses 2540 2540
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dbeatty10
changed the title
[tidy first] Replace
Replace Sep 16, 2024
TestSelector
with ResourceTypeSelector
TestSelector
with ResourceTypeSelector
This reverts commit ceecfec.
5 tasks
gshank
approved these changes
Sep 18, 2024
5 tasks
peterallenwebb
pushed a commit
that referenced
this pull request
Sep 20, 2024
* [tidy first] Replace `TestSelector` with `ResourceTypeSelector` * Changelog entry * Fully preserve current behavior * Revert "Fully preserve current behavior" This reverts commit ceecfec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NA
Problem
The
TestSelector
class was introduced in #2628, but it doesn't need to offer anything differentiated anymore.Solution
Simplify by standardizing upon the
ResourceTypeSelector
.This was accomplished by:
TestSelector
withResourceTypeSelector
TestSelector
classSome history of the
TestSelector
classTo help us avoid a Chesterton's fence situation:
data
andschema
expand_selection
data
andschema
expand_selection
Additional information
Doing this simple refactor makes it easy to see the root cause of the bug report in #10727.
Refactoring first will make it easier to review the code changes in #10706 (which will also resolve #10727).
Checklist