Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install postgres-16 in CI #10687

Merged
merged 32 commits into from
Sep 11, 2024
Merged

install postgres-16 in CI #10687

merged 32 commits into from
Sep 11, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 10, 2024

Resolves #8286

Problem

We need postgres >= 15 to test dbt-core code that depend on merge operations in dbt-postgres. Specifically this is blocking testing the new microbatch incremental strategy: #10594

Additionally, dbt-postgres is already using postgres 16 in CI so there is some inconsistency there.

Solution

Using: https://computingforgeeks.com/install-and-configure-postgresql-on-ubuntu/

Install postgres 16 onto ubuntu 20.04. We can also consider a service-based approach as what is done in dbt-postgres, but that will likely be a bigger refactor (#10688) + container services are only supported for linux runners. We'd still need to roll our own updates for macos + windows

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (1d3d315) to head (c8ad9ce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10687      +/-   ##
==========================================
- Coverage   88.92%   88.87%   -0.05%     
==========================================
  Files         180      180              
  Lines       22785    22785              
==========================================
- Hits        20261    20250      -11     
- Misses       2524     2535      +11     
Flag Coverage Δ
integration 86.10% <ø> (-0.14%) ⬇️
unit 62.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.36% <ø> (ø)
Integration Tests 86.10% <ø> (-0.14%) ⬇️

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Sep 10, 2024
@MichelleArk MichelleArk force-pushed the bump-postgres-ci branch 2 times, most recently from 70a1648 to c071ec8 Compare September 10, 2024 18:53
@MichelleArk MichelleArk changed the title take 1: install postgres-16 on linux install postgres-16 in Ci Sep 10, 2024
@MichelleArk MichelleArk changed the title install postgres-16 in Ci install postgres-16 in CI Sep 10, 2024
@MichelleArk MichelleArk force-pushed the bump-postgres-ci branch 12 times, most recently from 6766f52 to 03d9847 Compare September 11, 2024 04:33
@MichelleArk MichelleArk force-pushed the bump-postgres-ci branch 3 times, most recently from a0fb1fa to 2519d3c Compare September 11, 2024 05:19
@MichelleArk MichelleArk marked this pull request as ready for review September 11, 2024 14:06
@MichelleArk MichelleArk requested a review from a team as a code owner September 11, 2024 14:06
@MichelleArk
Copy link
Contributor Author

MichelleArk commented Sep 11, 2024

Going to merge this as-is for now, with some follow-up ideas to speed up windows runs:

Issue here: #10696

@MichelleArk MichelleArk merged commit ab500a9 into main Sep 11, 2024
67 of 68 checks passed
@MichelleArk MichelleArk deleted the bump-postgres-ci branch September 11, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2914] [Feature] Use PostgreSQL 15 for CI tests
2 participants